Fix ProtobufBundle.MinVersion #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #227 Signed-off-by: Cody Soyland <codysoyland@github.com>
codysoyland
force-pushed
the
codysoyland/issue227
branch
from
0d7fd9f
to
32f34f5
Compare
| }{ | ||
| {"old-format", "application/vnd.dev.sigstore.bundle+json;version=0.1", "v0.1", true}, | ||
| {"old-format-unexpected", "application/vnd.dev.sigstore.bundle+json;version=0.1", "v0.2", false}, | ||
| {"old-format-without-v", "application/vnd.dev.sigstore.bundle+json;version=0.1", "0.1", true}, |
There was a problem hiding this comment.
Do we want to support matching both with and without the preceding v, or should we standardize around one?
There was a problem hiding this comment.
I would favour the robustness principle here, i.e what's implemented.
As this is a simple helper function, requiring stricter formatting does not seem to aid in any correctness IMHO.
edit: grammer fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227
Signed-off-by: Cody Soyland codysoyland@github.com
Summary
Release Note
Documentation