Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include URI for CA verified timestamps #270

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

cmurphy
Copy link
Contributor

@cmurphy cmurphy commented Aug 12, 2024

Include the URI of the transparency log and timestamp authority for
verified timestamps in the final verification result. The URIs are
helpful for human readability of the result.

When the WithoutAnyObserverTimestampsUnsafe verify policy is selected,
there is no certificate authority, so the URI is left empty.

Fixes #193

Summary

Release Note

Documentation

Include the URI of the transparency log and timestamp authority for
verified timestamps in the final verification result. The URIs are
helpful for human readability of the result.

When the WithoutAnyObserverTimestampsUnsafe verify policy is selected,
there is no certificate authority, so the URI is left empty.

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
@cmurphy cmurphy marked this pull request as ready for review September 11, 2024 21:06
@cmurphy cmurphy requested a review from a team as a code owner September 11, 2024 21:06
Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@steiza steiza merged commit 057b442 into sigstore:main Sep 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate URIs for TimestampVerificationResult
4 participants