Don't fail on Rekor entry verification for untrusted entries #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steiza
reviewed
Dec 15, 2023
|
Looks good, and I agree with @steiza that we may want to have some option to get details on ignored signatures. I'm fine to merge this then track that as a separate issue as it would be a larger refactor (to cover TSAs too). |
kommendorkapten
previously approved these changes
Dec 15, 2023
Like sigstore#45, as long as the threshold of expected timestamps is met, then verification should succeed. Otherwise, entries without trust root material should be skipped. One benefit of having the log key ID be used to look up the correct trust root material is that we can still error out if the signature is invalid. Ref: sigstore#43 Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper
force-pushed
the
rekor-dont-fail-fast
branch
from
82b05ba to
dc51253
Compare
steiza
reviewed
Dec 15, 2023
Also add more tests Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
steiza
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #45, as long as the threshold of expected timestamps is met, then verification should succeed. Otherwise, entries without trust root material should be skipped.
One benefit of having the log key ID be used to look up the correct trust root material is that we can still error out if the signature is invalid.
Fixes #43
Summary
Release Note
Documentation