Verify required fields in Sigstore Bundle #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
commented
Jan 22, 2023
| @@ -38,7 +36,16 @@ public class BundleFactory { | |||
| public static String createBundle(KeylessSigningResult signingResult) { | |||
| Bundle bundle = BundleFactoryInternal.createBundleBuilder(signingResult).build(); | |||
| try { | |||
| return JSON_PRINTER.print(bundle); | |||
| String jsonBundle = BundleFactoryInternal.JSON_PRINTER.print(bundle); | |||
There was a problem hiding this comment.
I moved the static field to a different class so protobuf does not leak to the public API
|
Can we merge this and release |
|
oh hey sorry, I'm still on leave, but I have some time today to maybe get a bunch of things done in bulk. |
4 tasks
sigstore-java/src/main/java/dev/sigstore/bundle/BundleVerifierInternal.java
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/bundle/BundleVerifierInternal.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/bundle/BundleVerifierInternal.java
Outdated
Show resolved
Hide resolved
Previously, message_signature.signature was missing, and there was no check to capture that. Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
loosebazooka
added
safe to test
loosebazooka
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, message_signature.signature was missing, and there was no check to capture that.
The key non-test code here is
setSignature(ByteString.copyFrom(signingResult.getSignature()))inBundleFactoryInternal.Release Note
NONE
Documentation
NONE