Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove async from sigstore::trust::TrustRoot trait #346

Closed
flavio opened this issue Apr 9, 2024 · 1 comment
Closed

Remove async from sigstore::trust::TrustRoot trait #346

flavio opened this issue Apr 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@flavio
Copy link
Member

flavio commented Apr 9, 2024

Description

Currently (v0.8.0) the [sigstore::trust::TrustRoot] trait has two methods, both of them async. These methods have been made async because of internal implementation of sigstore::trust::sigstore::SigstoreTrustRoot.

Internally SigstoreTrustRoot has to initialize its trusted_root variable, which involves the usage of futures.
I think we can initialize this variable inside of the SigstoreTrustRoot::new method (which is already async) and simplify the trait definition.
@flavio flavio added the enhancement New feature or request label Apr 9, 2024
flavio added a commit to flavio/sigstore-rs that referenced this issue Apr 10, 2024
@flavio
refactor: remove async from sigstore::trust::TrustRoot trait
c6302b0 
Make the `sigstore::trust::TrustRoot` methods not async.

Fixes sigstore#346

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
@flavio flavio mentioned this issue Apr 10, 2024
Closed
@flavio
Copy link
Member Author

flavio commented Sep 17, 2024

Closing, this has been fixed in the meantime

@flavio flavio closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove async from trustroot trait flavio/sigstore-rs
1 participant
@flavio