Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect base64_signature doc comment #188

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jan 13, 2023

Summary

This commit updates the doc comment for the base64_signature field which I believe is incorrect
(I'm the one to blame for this, sorry!).

Release Note

NONE

Documentation

NONE

Signed-off-by: Daniel Bevenius daniel.bevenius@gmail.com

This commit updates the doc comment for the base64_signature field
which I believe is incorrect (I'm the one to blame for this, sorry!).

Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my fault too, since I was the one who reviewed the code 😅

No worries and thanks for the fix

@flavio flavio merged commit 8d22a6d into sigstore:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants