Update create_log_entry example to create key pair. #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavio
requested changes
Feb 7, 2023
flavio
requested changes
May 9, 2023
flavio
requested changes
May 18, 2023
flavio
previously approved these changes
May 30, 2023
Updates the example program create_log_entry to create the key pair used to sign and upload the data file into the Rekor transparency log. Therefore, the users do not need to create the files and generate the hashes required to create an transparency log entry. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
|
@jvanz I did a force push to fix a rebase conflict |
flavio
previously approved these changes
May 30, 2023
viccuad
reviewed
May 30, 2023
viccuad
reviewed
May 30, 2023
Address some typos inside of the comments Signed-off-by: Flavio Castelli <fcastelli@suse.com>
|
@viccuad can you please approve again? I fixed the 2 typos you reported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the example program create_log_entry to create the key pair used to sign and upload the data file into the Rekor transparency log. Therefore, the users do not need to create the files and generate the hashes required to create an transparency log entry.
Fix #104