Fix errors/warnings reported by clippy #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit attempts to address the errors/warnings reported by cargo clippy. Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
Fix the clippy error `result_large_err` in the proper way, instead of just ignoring it. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
flavio
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Thanks for the submission. I made a change to it, because I didn't want to just ignore the result_large_err error. I fixed it properly as suggested by clippy, by Box-ing the TUF error. That just required few map_err(Box::new) transformations when the code had to deal with the TUF library originating this error type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Bevenius daniel.bevenius@gmail.com
Summary
This commit attempts to address the errors/warnings reported by cargo clippy.
Release Note
NONE
Documentation
NONE