fix: make LogEntry Body an enum #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the LogEntry body field type to be an enum instead of a struct. This enum will contain a variant for the different types of rekords that can be stored in Rekor. The motivation for this change is that currently only Hashedrekord::Spec are supported as that is the type spec field in the current Body struct. For further details please see the linked issue. Closes: sigstore#243 Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
flavio
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #243
Summary
This commit updates the LogEntry body field type to be an enum instead of a struct. This enum will contain a variant for the different types of rekords that can be stored in Rekor.
The motivation for this change is that currently only Hashedrekord::Spec are supported as that is the type spec field in the current Body struct. For further details please see the linked issue.
Release Note
TODO:
Documentation
NONE