fix: ensure cosign client can be sent between threads #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After d9b198a got merged, the `Sync` and `Send` supertraits got removed from the `ClientCapabilities` trait. This was done to ensure the code could build when the `wasm32` target is used. Unfortunately, this makes impossible to send the cosign client between threads. This causes an error like the following one: ``` error: future cannot be sent between threads safely the trait `Send` is not implemented for `(dyn sigstore::registry::ClientCapabilities + 'static)` ``` This commit fixes the issue by introducing conditional compilation checks. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
|
Once this is merged I would like to tag the |
|
Hey I love this PR. Before this we have to create a temporary runtime to handle this |
Xynnn007
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After d9b198a got merged, the
SyncandSendsupertraits got removed from theClientCapabilitiestrait. This was done to ensure the code could build when thewasm32target is used.Unfortunately, this makes impossible to send the cosign client between threads. This causes an error like the following one:
This commit fixes the issue by introducing conditional compilation checks.