Increase the severity of missing SDK constraint. (dart-lang#419)

* Increase the severity of missing SDK constraint. * dartfmt
sigurdm · Sep 28, 2018 · 909f2c7 · 909f2c7
1 parent 86dcb16
commit 909f2c7
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 19 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.12.5-dev
+
+* Increase the severity of missing SDK constraint.
+
 ## 0.12.4
 
 * Documented how scoring works.

diff --git a/lib/src/maintenance.dart b/lib/src/maintenance.dart
@@ -221,12 +221,12 @@ Future<Maintenance> detectMaintenance(
   }
 
   if (!pubspec.hasDartSdkConstraint) {
-    maintenanceSuggestions.add(new Suggestion.warning(
+    maintenanceSuggestions.add(new Suggestion.error(
         SuggestionCode.pubspecSdkConstraintMissing,
         'Add SDK constraint in `pubspec.yaml`.',
         'For information about setting SDK constraint, please see '
         '[https://www.dartlang.org/tools/pub/pubspec#sdk-constraints](https://www.dartlang.org/tools/pub/pubspec#sdk-constraints).',
-        score: 5.0));
+        score: 50.0));
   }
 
   if (pubspec.shouldWarnDart2Constraint) {

diff --git a/lib/src/version.dart b/lib/src/version.dart
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: pana
 description: Evaluate the health and quality of a Dart package
-version: 0.12.4
+version: 0.12.5-dev
 homepage: https://github.com/dart-lang/pana
 author: Dart Team <misc@dartlang.org>
 

diff --git a/test/end2end/skiplist-0.1.0.json b/test/end2end/skiplist-0.1.0.json
@@ -57,20 +57,20 @@
     "isExperimentalVersion": false,
     "isPreReleaseVersion": false,
     "suggestions": [
+      {
+        "code": "pubspec.sdk.missing",
+        "level": "error",
+        "title": "Add SDK constraint in `pubspec.yaml`.",
+        "description": "For information about setting SDK constraint, please see [https://www.dartlang.org/tools/pub/pubspec#sdk-constraints](https://www.dartlang.org/tools/pub/pubspec#sdk-constraints).",
+        "score": 50.0
+      },
       {
         "code": "platform.conflict.inPkg",
         "level": "error",
         "title": "Fix platform conflicts.",
         "description": "Error(s) prevent platform classification:\n\nFix dependencies in `pubspec.yaml`.",
         "score": 20.0
       },
-      {
-        "code": "pubspec.sdk.missing",
-        "level": "warning",
-        "title": "Add SDK constraint in `pubspec.yaml`.",
-        "description": "For information about setting SDK constraint, please see [https://www.dartlang.org/tools/pub/pubspec#sdk-constraints](https://www.dartlang.org/tools/pub/pubspec#sdk-constraints).",
-        "score": 5.0
-      },
       {
         "code": "pubspec.description.tooShort",
         "level": "hint",

diff --git a/test/maintenance_test.dart b/test/maintenance_test.dart
@@ -24,6 +24,14 @@ final _withIssuesJson = {
   "isPreReleaseVersion": true,
   "dartdocSuccessful": false,
   "suggestions": [
+    {
+      'code': 'pubspec.sdk.missing',
+      'level': 'error',
+      'title': 'Add SDK constraint in `pubspec.yaml`.',
+      'description':
+          'For information about setting SDK constraint, please see [https://www.dartlang.org/tools/pub/pubspec#sdk-constraints](https://www.dartlang.org/tools/pub/pubspec#sdk-constraints).',
+      'score': 50.0,
+    },
     {
       'code': 'platform.conflict.inPkg',
       'level': 'error',
@@ -78,14 +86,6 @@ final _withIssuesJson = {
           'Update the `homepage` property: create a website about the package or use the source repository URL.',
       'score': 10.0,
     },
-    {
-      'code': 'pubspec.sdk.missing',
-      'level': 'warning',
-      'title': 'Add SDK constraint in `pubspec.yaml`.',
-      'description':
-          'For information about setting SDK constraint, please see [https://www.dartlang.org/tools/pub/pubspec#sdk-constraints](https://www.dartlang.org/tools/pub/pubspec#sdk-constraints).',
-      'score': 5.0,
-    },
     {
       'code': 'example.missing',
       'level': 'hint',