chore: add eslint-plugin-node #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will warn us against unsupported features without waiting for CI to run Also upgrade all dated dependencies
SimenB
commented
Sep 20, 2018
lib/summary.js
Outdated
| @@ -13,7 +13,7 @@ const validateLabels = require('./validation').validateLabel; | |||
| const validateMetricName = require('./validation').validateMetricName; | |||
| const validateLabelNames = require('./validation').validateLabelName; | |||
| const TDigest = require('tdigest').TDigest; | |||
| const isObject = require('util').isObject; | |||
| const isObject = require('./util').isObject; | |||
There was a problem hiding this comment.
probably a typo, but isObject from core util module is deprecated
SimenB
commented
Sep 20, 2018
| @@ -9,7 +9,7 @@ | |||
| "index.d.ts" | |||
| ], | |||
| "engines": { | |||
| "node": ">=6" | |||
| "node": ">=6.1" | |||
There was a problem hiding this comment.
6.1 for cpuUsage. Probably OK to sneak in here, it's years old by this point
|
The second commit uses object destructuring instead of importing the same module multiple times (hitting the require cache, so just verbosity, no perf hit). Recommended to review individual commits |
zbjornson
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will warn us against unsupported features without waiting for CI
to run
Also upgrade all dated dependencies
Motivation is if we use e.g. Object.entries, we normally have to wait for CI to fail. Now we'll get a linting error in our IDE or precommit: