Reset internal histogram of monitorEventLoopDelay after each collect() invocation #459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses problem described at #370.
I've read attentively that issue and propositions about the solution. Anyway after own investigation of the code I've decided that simple calling
histogram.reset()
after eachcollect()
invocation will be simply enough.Event loop lag metrics is important for us because we want to see how our application handles spikes and how internal event loop lag increases, to determine easier, there is hiding the bottleneck. Currently we just cannot see that, because
nodejs_eventloop_lag_seconds
represents just single measurement result (so it is pretty random, as noticed already at #309) andnodejs_eventloop_lag_mean_seconds
shows mean value for overall process lifetime and I cannot imagine, how to use such information in our case and for what cases it can be useful at all.If all collected now event loop lag values will represent only scrape interval period that will be simply enough for us and I think that for everyone too.