Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes description for setToCurrentTime to seconds instead of milliseconds #585

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Fixes description for setToCurrentTime to seconds instead of milliseconds #585

merged 3 commits into from
Sep 10, 2023

Conversation

alarobric
Copy link
Contributor

Fixes #568
This was broken since the change in #167 in v11.0.0

@SimenB
Copy link
Collaborator

SimenB commented Sep 7, 2023

Thanks! Could you update the changelog as well?

@alarobric
Copy link
Contributor Author

Sure, done now.

SimenB
SimenB approved these changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 07e9a3c into siimon:master Sep 10, 2023
13 checks passed
@alarobric alarobric deleted the setToCurrentTime-unit branch September 11, 2023 06:22
@lholmquist lholmquist mentioned this pull request Jun 5, 2024
Closed
@doperiddle doperiddle mentioned this pull request Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alarobric @SimenB