Minor stuff (apache#17)

* Create pulsar-functions module (#1) * Create pulsar-functions module * rename `sdk` package to `api` * Added the first cut of the Java interface for Pulsar functions (#2) * Added join interface to Spawner.
sijie · Mar 4, 2018 · 5b0ed1b · 5b0ed1b
1 parent 98d208d
commit 5b0ed1b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
@@ -99,9 +99,7 @@ void run() throws Exception {
                 admin.getServiceUrl().toString());
 
             spawner.start();
-
-            CountDownLatch latch = new CountDownLatch(1);
-            latch.await();
+            spawner.join();
         }
 
     }

diff --git a/.../src/main/java/org/apache/pulsar/functions/runtime/container/ThreadFunctionContainer.java b/.../src/main/java/org/apache/pulsar/functions/runtime/container/ThreadFunctionContainer.java
@@ -121,8 +121,6 @@ public void start() throws Exception {
         // make sure the function class loader is accessible thread-locally
         fnThread.setContextClassLoader(fnClassLoader);
 
-        // javaInstance = new JavaInstance(javaInstanceConfig);
-
         // start the function thread
         fnThread.start();
     }

diff --git a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/spawner/Spawner.java b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/spawner/Spawner.java
@@ -68,6 +68,10 @@ public void start() throws Exception {
         functionContainer.start();
     }
 
+    public void join() throws Exception {
+        functionContainer.join();
+    }
+
     private String createSubscriptionName() {
         return "spawner-" + assignmentInfo.getFunctionConfig().getName() + "-" + assignmentInfo.getFunctionVersion()
                 + "-" + assignmentInfo.getFunctionId();