Allow for debug and production builds of Monaco JS files #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rust debug mode, debug build is used, thus minification and obfuscation step is skipped. In Rust release mode, JS files are minified allowing for maximum performance.
siku2
reviewed
Mar 22, 2022
|
Done. And changed |
Great, I was gonna suggest that too but didn't want to be too pedantic :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rust debug mode, debug build is used, thus minification and name mangling step is skipped.
In Rust release mode, JS files are minified allowing for maximum performance.
I'm not sure if this is the best approach. Maybe we should use some feature flag instead of basing on build mode?
Nevertheless we should allow for using builds with nonminified files and without names mangled, because it really helps debugging and hacking Monaco editor.