This repository was archived by the owner on Feb 7, 2025. It is now read-only.
Conversation
briskt
requested review from
hobbitronics and
jason-jackson
and removed request for
a team
|
hobbitronics
approved these changes
Dec 10, 2024
hobbitronics
left a comment
hobbitronics
left a comment
There was a problem hiding this comment.
Out of curiosity what is the specific reason for using p.log.Debug vs p.log.Info?
Contributor
Author
Well, in this case, it's just to avoid noise in the logs. I'd like to come up with a set of rules to help decide what level to use, though I'm not sure that would be all that effective either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ETH-1042 Redirect Error