Skip to content

Convert to actions#8

Merged
jason-jackson merged 5 commits into8.1from
feature/actions
Mar 7, 2024
Merged

Convert to actions#8
jason-jackson merged 5 commits into8.1from
feature/actions

Conversation

@jason-jackson
Copy link
Contributor

Changes:

  • Convert to Github actions (both on schedule and on push)
  • Clean up README
  • Change MAINTAINER in README to label

Note: It might be easier to view without cleanup here.

@jason-jackson jason-jackson requested a review from a team March 7, 2024 18:37
tags: |
type=ref,event=branch
# set latest tag for main branch
type=raw,value=latest,enable={{is_default_branch}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm suspicious about using is_default_branch. We may change the default branch at some point, not realizing it would affect the image tag. Or maybe I'm not understanding the situation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can comment that better in the README. Scheduled builds only build the default branch, So we will want to update the default branch to whatever the latest version is. Alternatively, we could always update main whenever we update the latest branch or make a new branch. Which theoretically we should have already been doing, but haven't

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jason-jackson Check my understanding here. It looks like this will run at 1:07 am on the 8th day of each month, and I think you said scheduled GitHub Actions only run on the default branch of the repo. It will build the docker image and then tag it (1) as latest if it's the default branch (won't it always be?) and (2) tag it with the branch name (e.g. 8.1).

Is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct. Currently scheduled build was for 1am on the 8th day of the month, but due to warning, I pushed it out a few minutes.

It might not always be pushed to the default branch. It will create a tag for every push to any branch with the branch name as the tag (with certain characters changed if needed). The on has both push and schedule so it will do it for both of them. See https://hub.docker.com/r/silintl/php8.

@jason-jackson jason-jackson merged commit 7cdd8a8 into 8.1 Mar 7, 2024
@jason-jackson jason-jackson deleted the feature/actions branch March 7, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants