Remove DockerHub push #307
Conversation
|
Should this change be highlighted in the README since this is used by others? |
Appears to not need the additional parameters.
|
@briskt I needed to adjust the install for |
| @@ -1,5 +1,5 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| apk add bats --update-cache --repository http://dl-3.alpinelinux.org/alpine/edge/community/ --allow-untrusted | |||
There was a problem hiding this comment.
This isn't docker hub, so I don't understand the removal.
There was a problem hiding this comment.
I don't think it has to do with Docker Hub, but it apparently broke since the last time the test was run. What isn't clear is why the alternate repository was used at all.
There was a problem hiding this comment.
apt install fails on containers in debian without an update, I think the --update-cache might be good to keep.
briskt
left a comment
briskt
left a comment
There was a problem hiding this comment.
Looks OK to me, though I think some mention should be made, in a prominent place like the README, about dropping the Docker Hub image. But in reality I think nobody, including our team, uses the Docker image at all. We just pull the script directly from GitHub. So I'd recommend deleting the entire build/push and just leave the test.
| @@ -1,5 +1,5 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| apk add bats --update-cache --repository http://dl-3.alpinelinux.org/alpine/edge/community/ --allow-untrusted | |||
There was a problem hiding this comment.
I don't think it has to do with Docker Hub, but it apparently broke since the last time the test was run. What isn't clear is why the alternate repository was used at all.
3 participants
Removed