Let the CLI take charge in Docker, overhaul localization #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bridges the gab between system system-installations where building the main binary in the root dir is what autoconf / automake wants us to do and submodule / directory usage where we encourage people to add our bin to their $PATH.
alerque
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, this lets the CLI take charge in Docker. The CLI is the entry point now. At this point it can basically invoke
makeand/or pass through other shell commands. It can also launch an interactive shell with some environment things normalized. You can still get a regular bash shell in the Docker image by manually usingdocker run --entrypoint=bashor whatever.Additionally this refactors a bunch of how the rust module scope is put together and introduces much more idiomatic way of accessing translated strings.