Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages): Correct math greek symbols and their var-alternate #2135

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Omikhleia
Copy link
Member

@Omikhleia Omikhleia commented Oct 16, 2024

Closes #2134

Or does it? Who knows, it breaks test tests/math-bigops.xml due to the bogus epsilon. Surely whoever wrote this test checked again LaTeX, right?

EDIT: For the record, Typst deviates slightly from LaTeX https://qwinsi.github.io/tex2typst-webapp/cheat-sheet.html

  • It has the \varxxx.. symbols as xxx.alt
  • Except that epsilon and phi are inverted (the .alt variants are the non-var ones)

@Omikhleia Omikhleia requested a review from a team as a code owner October 16, 2024 01:52
@OlivierNicole
Copy link
Member

Or does it? Who knows, it breaks test tests/math-bigops.xml due to the bogus epsilon. Surely whoever wrote this test checked again LaTeX, right?

I don’t remember, but it wasn’t deeply thought out. I think you should modify the test reference based on the decision that you take regarding the symbol names.

@Omikhleia Omikhleia added the bug Software bug issue label Oct 17, 2024
@Omikhleia Omikhleia self-assigned this Oct 17, 2024
@Omikhleia Omikhleia added this to the v0.15.6 milestone Oct 17, 2024
@Omikhleia Omikhleia force-pushed the fix-math-tex-greek-aliases branch from 5552f93 to dcca7c8 Compare October 17, 2024 17:35
@Omikhleia Omikhleia requested a review from alerque as a code owner October 17, 2024 17:35
@Omikhleia
Copy link
Member Author

Fixed the broken test to use \varepsilon for ε, in compliance with TeX math's expectations (= output unchanged, an inline with the MathML case which uses an explicit ε).

@alerque alerque merged commit e78a407 into sile-typesetter:master Oct 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TeX-like phi, varphi and friends...
3 participants