Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (most) of the wildcard hacks from automake #953

Merged
merged 9 commits into from
Jul 16, 2020

Conversation

alerque
Copy link
Member

@alerque alerque commented Jul 16, 2020

Closes #951.

This is a bit awkward, but I've been thinking about this now and then for years and nothing better has occurred to me. Fighting automake is not fun, using it as intended is actually not too bad. This punts most of the ways we were trying to be too smart for it to a shell script.

The biggest downside is currently you can't skip straight from ./configure to make dist, you have to make in between. Working on that bit, maybe...

@alerque alerque added ci Continuous integration pipelines tooling Build tooling, release management, and packaging processes labels Jul 16, 2020
@alerque alerque added this to the v0.10.6 milestone Jul 16, 2020
@alerque
Copy link
Member Author

alerque commented Jul 16, 2020

Okay back to one step from ./configure to make dist (which wasn't that important because only people cutting releases and testing the process are going to hit that issue, but it does make testing less error-prone).

The whole lua_modules_dist thing is frankly a lot of pain for little gain. Realistically all the distros that care about self contained packages that don't need internet connections to build (i.e. don't want to call out to luarocks install ... are also the ones that use --with-system-luarocks and so don't care about the bundled sources anyway. It might be okay to drop that whole mess someday.

@alerque alerque marked this pull request as ready for review July 16, 2020 19:25
@alerque alerque force-pushed the less-auto-automake branch from b83482f to f269da7 Compare July 16, 2020 20:18
@alerque
Copy link
Member Author

alerque commented Jul 16, 2020

For the record the only remaining use of $(wildcard ...) is okay I think. It can be allowed to fail with an empty list, it isn't used by automake at all (no packaging/dist related data), and is only an optimization to speed up rebuilds.

@alerque alerque merged commit bacaf68 into sile-typesetter:master Jul 16, 2020
@alerque alerque deleted the less-auto-automake branch July 16, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration pipelines tooling Build tooling, release management, and packaging processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI‌ generated package artifacts aren't usable like regular dist builds
1 participant