Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where an unexpected newline is inserted when formatting fun () -> ?assertMatch(..., ...) end.. #108

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

sile
Copy link
Owner

@sile sile commented Sep 15, 2024

Copilot Summary

This pull request includes changes to the efmt_core module to improve the formatting logic and enhance the test coverage. The most important changes include modifying the Formatter implementation to handle single-line mode and skipping logic more effectively, and updating the test cases to include additional scenarios for macro formatting.

Improvements to formatting logic:

  • efmt_core/src/format.rs: Adjusted the Formatter implementation to correctly handle single-line mode and skipping logic, ensuring that pending_blank is managed appropriately.

Enhancements to test coverage:

  • efmt_core/src/items/macros.rs: Updated the assert_match test to include multiple scenarios, improving the robustness of macro formatting tests.

@sile sile merged commit 46fb34b into master Sep 15, 2024
10 checks passed
@sile sile deleted the fix-assert-match-in-fun branch September 15, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant