Remove extra newlines between -doc attributes and function definitions
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #109
Copilot Summary
This pull request introduces support for handling documentation attributes in the Erlang formatter. The changes mainly involve adding a new
Docattribute type and updating the formatting logic to accommodate it.Support for Documentation Attributes
efmt_core/src/items/forms.rs: AddedDocto theFormenum and implemented theFormattrait for it. Also, added theDocAttrstruct to represent the documentation attribute. [1] [2] [3]efmt_core/src/items.rs: Updated theis_func_specmethod tois_func_spec_or_docto include the newDocattribute.efmt_core/src/items/module.rs: Modified theFormatStatestruct and related logic to handle the newDocattribute. [1] [2] [3]Parsing and Atoms
efmt_core/src/items/atoms.rs: Added a newDocAtomstruct and implemented parsing for it.efmt_core/src/items/forms.rs: ImportedDocAtomto use in theDocAttrstruct.Tests
efmt_core/src/items/forms.rs: Added tests to ensure theDocattribute is correctly parsed and formatted.tests/testdata/doc.erl: Added test cases for theDocattribute.tests/testdata/long_spec.erlandtests/testdata/otp27_strings.erl: Minor adjustments to existing test data files. [1] [2]