convert erl_anno:anno() to integer() at transform #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dw-kihara
commented
Sep 20, 2023
| @@ -111,7 +111,7 @@ transform_call(logi, Severity0, {_, _, _, Args} = Call, Loc = #location{line_or_ | |||
| [Logger, {string, _, _} = Fmt] -> | |||
| Opts = {cons, LineOrAnno, {tuple, LineOrAnno, [{atom, LineOrAnno, logger}, Logger]}, {nil, LineOrAnno}}, | |||
| logi_call_expr(Severity, Fmt, {nil, LineOrAnno}, Opts, Loc); | |||
| [Logger, {string, _, _} = Fmt, {nil, LineOrAnno} = Data] -> | |||
| [Logger, {string, _, _} = Fmt, {nil, _} = Data] -> | |||
There was a problem hiding this comment.
When anno contains column, LineOrAnno that is bound at #location{line_or_anno = LineOrAnno} will not match here.
dw-kihara
commented
Sep 20, 2023
| @@ -136,7 +136,7 @@ logi_location_expr(Loc = #location{line_or_anno = LineOrAnno}) -> | |||
| {atom, LineOrAnno, Loc#location.application}, | |||
| {atom, LineOrAnno, Loc#location.module}, | |||
| {atom, LineOrAnno, Loc#location.function}, | |||
| {integer, LineOrAnno, LineOrAnno} | |||
| {integer, LineOrAnno, logi_transform_utils:line_or_anno_to_line(LineOrAnno)} | |||
There was a problem hiding this comment.
When anno contains column, this made malformed abstract format values like {integer, {10, 12}, {10, 12}} wherer the third element must be an integer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of treating erl_anno:anno() in #3 has the following problems. (I'm very sorry.)
logi_location:unsafe_new/5acceptsline_or_anno() :: line() | erl_anno:anno()whereerl_anno:anno()is opaque{10, 12}are placed after transform, dialyzer raises an error that says no compatible typeslogi_transform:logi_location_expr/1makes malformed abstract format values like{integer, {10, 12}, {10, 12}}This PR addresses these problems by converting
erl_anno:anno()tointeger()in the logi_transform process.In addition, this fixes unintended pettern match in v0.0.12-compatible transform when Data is
[].