Improve developer experience #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jingyuexing
commented
May 19, 2023
jingyuexing
commented
- feat: 添加字符串模板替换
- feat: 序列化Query请求字符串
feat: 添加模板字符串解析以及模板字符串单元测试
|
please fix ci |
i'm trying |
houseme
reviewed
May 20, 2023
util/query.go
Outdated
| for key, value := range params { | ||
| valueString := "" | ||
| switch v := value.(type) { | ||
| case int, int8, int16, int32, int64: |
There was a problem hiding this comment.
是不是参数是 interface 应该考虑一下 uint uint8 uint32 uint64 这些类型？
houseme
reviewed
May 20, 2023
| if response, err = util.HTTPGet(strings.Join([]string{ | ||
| userSimpleListURL, | ||
| util.Query(map[string]interface{}{ | ||
| "access_token": accessToken, |
There was a problem hiding this comment.
access_token，department_id 可以搞成静态常量
There was a problem hiding this comment.
access_token，department_id可以搞成静态常量
可以设置全局的配置项,这个应该是由整个框架负责
There was a problem hiding this comment.
access_token，department_id可以搞成静态常量可以设置全局的配置项,这个应该是由整个框架负责
目前没这样处理，那这次就处理一下，建立统一的常量管理，access_token，出现的地方还蛮多的。可以在根目录下面建一个常量管理文件以及每个子目录再建一个常量文件
|
没有人review吗？ |
这个功能是急需使用吗？ |
houseme
approved these changes
May 31, 2023
我开发的时候要用到的 |
先根据 commit 获取最新的代码 |
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.