Improved how expressions are simplified to eliminate sub-expressions that can be evaluated #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes how the
simplify()
function works when dealing with expressions that can be simplified even further.Example 1:
Before the change, this would have evaluated to something like
true and (true or (true))
. Yet, since this is an expression that can already be simplified to a single literal, it now evaluates to:true
Example 2:
Now, when running
simplify()
, this will evaluate totrue or (x > 8)
. When runningsimplify({x: 10})
, this will evaluate totrue
.