Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter warnings #45

Open
lexoyo opened this issue Jan 31, 2018 · 4 comments
Open

Linter warnings #45

lexoyo opened this issue Jan 31, 2018 · 4 comments

Comments

@lexoyo
Copy link
Member

lexoyo commented Jan 31, 2018

We should cleanup the code to remove linter warnings, i.e. do npm run lint and fix the warnings

@JbIPS
Copy link
Contributor

JbIPS commented Jan 31, 2018

Good idea but most of the warnings are not trivial :

  • no-console, meaning we need to choose a logger strategy
  • no-alert, basically the same thing
  • class-method-use-this, meaning we need to refactor some classes to use static methods as much as possible

So this will be needed soon, but not sure it's a good first issue 😉

@louisauve
Copy link

Hello Jb ! Maybe could I just delete the console.log ? Alex told me it should be enough to fix this issue.

@JbIPS
Copy link
Contributor

JbIPS commented Feb 4, 2018

Hello @louisauve and welcome in this project! If @lexoyo said they're not needed, remove them 😃

JbIPS pushed a commit that referenced this issue Oct 5, 2018
fix lint warnings #45
@lexoyo lexoyo closed this as completed Oct 10, 2018
@lexoyo
Copy link
Member Author

lexoyo commented Oct 15, 2018

I reopen this issues as there are still warnings and even a few errors, am I right?

@lexoyo lexoyo reopened this Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants