skip omegaconf to avoid stack overflow due to recursive calls #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
strint
reviewed
Dec 5, 2023
| @@ -86,6 +86,8 @@ def update_class_proxies(self, class_proxy_dict: Dict[str, type], verbose=True): | |||
| self.logger.debug(debug_message) | |||
|
|
|||
| def _transform_entity(self, entity): | |||
| if "omegaconf" in str(entity): | |||
| return entity | |||
There was a problem hiding this comment.
这个写得太具体了，没法合并。需要理清为什么，然后想个更系统的策略。
是因为那个 getattr 带来的吧
There was a problem hiding this comment.
这个之前跟冯文反复讨论过。暂时只想到这种方式来处理。
There was a problem hiding this comment.
这里为什么会导致递归调用呢，把原因写清楚吧。
即使要这样，也需要十足的理由。
There was a problem hiding this comment.
我在这个分支简化了这块的工作逻辑，#376
可以尝试下看有没有关系
There was a problem hiding this comment.
omegaconf 不赖torch 。mock中应该直接是返回 omegaconf 包中对象。这个pr 应该不用修改。
现在这个导致递归调用 是现在mock 机制的问题 . 具体的稍后 我找个 demo 。
There was a problem hiding this comment.
我这里注册之后，应该不会触发这个问题了。
There was a problem hiding this comment.
下面代码可复现导致递归的问题。
from omegaconf.dictconfig import DictConfig
from onediff.infer_compiler.transform import register, torch2oflow
config = DictConfig({"local_server": {"port": 8080, "host": "localhost"}})
# ### 解决方式 1
# def func(mod: DictConfig):
# return mod
# register(torch2oflow_funcs=[func])
# ### end 解决方式 1
of_config = torch2oflow(config)输出
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'omegaconf.base.ContainerMetadata'> e=RecursionError('maximum recursion depth exceeded while calling a Python object')
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'omegaconf.dictconfig.DictConfig'> e=RecursionError('maximum recursion depth exceeded')
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'omegaconf.nodes.AnyNode'> e=RecursionError('maximum recursion depth exceeded')
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'omegaconf.nodes.AnyNode'> e=RecursionError('maximum recursion depth exceeded')
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'type'> e=AttributeError("module 'builtins' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'type'> e=AttributeError("module 'builtins' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'type'> e=AttributeError("module 'builtins' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'type'> e=AttributeError("module 'builtins' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'type'> e=AttributeError("module 'builtins' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'type'> e=AttributeError("module 'builtins' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'type'> e=AttributeError("module 'builtins' has no attribute '__path__'")
ERROR [2023-12-05 08:25:47] - Unsupported type: <class 'typing._SpecialForm'> e=AttributeError("module 'typing' has no attribute '__path__'")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip omegaconf to avoid stack overflow due to recursive calls when calling oneflow_compile in stability-difussion-webui