-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add context manager TensorInplaceAssign
#396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Inc/diffusers into dev_wy_add_AutoInplaceCopyTensor
…-Inc/diffusers into dev_wy_add_AutoInplaceCopyTensor
marigoold
changed the title
[WIP] add AutoInplaceCopyTensor
add context manager Dec 5, 2023
AutoInplaceAssign
strint
reviewed
Dec 5, 2023
dptr1 = eager.linear1.weight.data.data_ptr() | ||
dptr2 = eager.linear2.weight.data.data_ptr() | ||
|
||
with AutoInplaceAssign(eager): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你用这个解决下 lora un-fuse 那个问题看看
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AutoInplaceAssign -> TensorInplaceAssign
Auto 没有什么含义
marigoold
changed the title
add context manager
add context manager Dec 7, 2023
AutoInplaceAssign
TensorInplaceAssign
这个 PR 需要配合一个 lora unfuse 的测试吧 |
把 #407 合并到这里,并增加下那个 unfuse lora 的测试吧 |
strint
reviewed
Dec 12, 2023
strint
reviewed
Dec 12, 2023
strint
reviewed
Dec 12, 2023
strint
approved these changes
Dec 13, 2023
strint
reviewed
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在 diffusers 中,load LoRA 的实现是直接把 fuse 之后的 weight 赋值给 self.weight(比如这里),这会使赋值后 tensor 的内存地址改变,而 graph 依然使用原来的内存地址,导致 LoRA 无法正确加载。
这里实现了一个 Tensor 和 Parameter 的子类,重写了 property data 的 getter 和 setter,使其 set 的时候原地拷贝,不改变内存地址。
正确性验证: