Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compilation failure of resnet50 and faster_rcnn #491

Merged
merged 15 commits into from
Jan 15, 2024
Merged

fix compilation failure of resnet50 and faster_rcnn #491

merged 15 commits into from
Jan 15, 2024

Conversation

haoyang9804
Copy link
Contributor

@haoyang9804 haoyang9804 commented Jan 4, 2024 •
edited
Loading

修复了这个oneflow_compile resnet50和faster_rcnn报错的问题

@haoyang9804 haoyang9804 requested a review from strint January 4, 2024 07:50
@haoyang9804
Copy link
Contributor Author

haoyang9804 commented Jan 8, 2024 •
edited
Loading

在这个分支上编译faster_rcnn也会报出attribute相关的问题
Screenshot from 2024-01-08 15-38-26
其本质原因与这个pr试图修复的resnet50编译错误相似，都是算子对齐失败导致torch2flow报错。
resnet50的问题是PyTorch的算子不具有oneflow的同样功能的算子的某些attribute，比如channel_axis。这使得在构建oneflow算子时，需要根据环境变量构造这些attr的值，正如该pr的修改方式。
faster_rcnn的问题是（如图所是）PyTorch的resnet50算子具有out_channels，然而这个attr在oneflow中不存在。

@haoyang9804 haoyang9804 changed the title fix compilation failure for resnet50 fix compilation failure of resnet50 and faster_rcnn Jan 10, 2024
levi131
levi131 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@levi131 levi131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levi131 levi131 requested review from levi131 and strint January 13, 2024 07:54
@haoyang9804 haoyang9804 force-pushed the fix_compilation_failure_resnet50 branch from 583693c to 3a745a6 Compare January 14, 2024 12:22
levi131
levi131 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@levi131 levi131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levi131 levi131 merged commit f140f0c into main Jan 15, 2024
2 of 4 checks passed
@levi131 levi131 deleted the fix_compilation_failure_resnet50 branch January 15, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levi131 levi131 levi131 approved these changes

@strint strint strint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haoyang9804 @strint @levi131