view comfyui log #534
Merged
view comfyui log #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto add_comfyui_ci_log
.github/workflows/examples.yml
Outdated
Comment on lines
199
to
200
| docker cp ${{ env.CONTAINER_NAME }}:/app/ComfyUI/onediff_comfyui.log . | ||
| cat ./onediff_comfyui.log && rm ./onediff_comfyui.log |
There was a problem hiding this comment.
这里为什么不用 docker exec 直接 cat 呢
There was a problem hiding this comment.
好的，改了。昨天先用 docker exec -it 不行，就先用上面的土方法了
.github/workflows/examples.yml
Outdated
Comment on lines
187
to
189
| docker cp ${{ env.CONTAINER_NAME }}:/app/ComfyUI/onediff_comfyui.log . | ||
| cat ./onediff_comfyui.log | ||
| rm ./onediff_comfyui.log |
There was a problem hiding this comment.
或者是我没想到更好的办法。但这个其实不重复，是我没得办法才写得这么冗余，因为：
python3 test_by_ui.py执行失败后，需要打印日志并退出- 如果不在这里通过这种方法打印，
python3 test_by_ui.py失败后，CI 就提前结束了，后面的打印是没机会执行的 - 所以这里的逻辑是：
python3 test_by_ui.py成功，就不打印日志（等到后面会有专门打印的步骤）；但是如果失败了，就需要在这里打印，并出错退出 CI
| local workflow_name="$1" | ||
| docker exec -w /src/onediff/tests/comfyui ${{ env.CONTAINER_NAME }} python3 test_by_ui.py --comfy_port 8188 --workflow "$workflow_name" || { | ||
| docker exec ${{ env.CONTAINER_NAME }} cat /app/ComfyUI/onediff_comfyui.log | ||
| false |
jackalcooper
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comfyui workflow 失败的情况，打印 comfyui 的运行日志。方便根据 CI 日志定位问题。