Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dynamic for comfy #535

Merged
merged 15 commits into from
Jan 24, 2024
Merged

Enable dynamic for comfy #535

merged 15 commits into from
Jan 24, 2024

Conversation

strint
Copy link
Collaborator

@strint strint commented Jan 18, 2024

No description provided.

@doombeaker
Copy link
Contributor

Traceback (most recent call last):
  File "/app/ComfyUI/nodes.py", line 1810, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/app/ComfyUI/custom_nodes/onediff_comfy_nodes/__init__.py", line 2, in <module>
    from ._config import _USE_UNET_INT8
  File "/app/ComfyUI/custom_nodes/onediff_comfy_nodes/_config.py", line 23, in <module>
    import register_onediff_quant  # load plugins
  File "/app/ComfyUI/custom_nodes/onediff_comfy_nodes/infer_compiler_registry/register_onediff_quant.py", line 4, in <module>
    import onediff_quant
ModuleNotFoundError: No module named 'onediff_quant'

Cannot import /app/ComfyUI/custom_nodes/onediff_comfy_nodes module for custom nodes: No module named 'onediff_quant'

CI 挂了直接原因是插件启动时出这个错了,不过日志没打印出来也有问题。这个 PR 里我修一下

- name: Install onediff-quant if needed
if: matrix.image == 'onediff-pro:cu121'
run: |
docker exec ${{ env.CONTAINER_NAME }} python3 -m pip install --pre onediff-quant -f https://oneflow-pro.oss-cn-beijing.aliyuncs.com/onediff-quant/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pro 版本的测试依赖 onediff-quant。现在先这样安装了(2.7 M 不大)。之后合并到镜像里更合理。

cc: @jackalcooper

@@ -184,6 +188,7 @@ jobs:
run_comfy_test() {
local workflow_name="$1"
docker exec -w /src/onediff/tests/comfyui ${{ env.CONTAINER_NAME }} python3 test_by_ui.py --comfy_port 8188 --workflow "$workflow_name" || {
echo "test_by_ui.py fails! print the ComfyUI logs..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常奇怪,这种情况下, comfyui 的日志是没有内容的,重定向文件的大小是 0,即使我先杀掉 comfy 进程再查看文件大小,也是 0.

这里就先打印个输出,证明运行到此处了。 失败情况下 comfyui 的日志内容如何显示,作为另外的任务解决。

(奇怪的是,运行成功情况下,可以打印 cofyui 日志)

@doombeaker doombeaker merged commit 25d2baf into main Jan 24, 2024
5 checks passed
@doombeaker doombeaker deleted the fix_dynamic_for_comfy branch January 24, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants