Fix Check Failed Error #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strint
reviewed
Jan 30, 2024
strint
reviewed
Jan 30, 2024
| if count != input_count: | ||
| logger.warning( | ||
| f"{type(cls._deployable_module_model.oneflow_module)} input count changed, will reload graph. " | ||
| f"When setting the strength parameter in the 'Apply ControlNet' node, please exercise caution. " |
There was a problem hiding this comment.
这个说明不太通用。可以当前使用输入的 tensor 的个数是否变化来判断是否要重新编译一个图，当前出现了变化，所以会新编译一个图。
There was a problem hiding this comment.
修改为 f"Module {type(self._deployable_module_model.oneflow_module)} input tensor count changed from {count} to {input_count}, will compile again."
strint
reviewed
Jan 30, 2024
| self._deployable_module_dpl_graph = None | ||
| self._load_graph_first_run = True | ||
|
|
||
| self._deployable_module_input_count = input_count |
There was a problem hiding this comment.
只有 count != input_count 才更新 _deployable_module_input_count ？
There was a problem hiding this comment.
已修改为 只有 count != input_count 才更新 _deployable_module_input_count
strint
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改 因为模型输入参数数量改变的 check failed 行为，目前 发现模型输入参数数量改变，让其重新加载图文件。
