reduce transpose operations to speedup #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjchen2
commented
Jan 30, 2024
| @@ -450,7 +450,9 @@ def forward( | |||
| # hidden_states = hidden_states.reshape(batch_frames, height, width, inner_dim).permute(0, 3, 1, 2).contiguous() | |||
| # Rewrite for onediff SVD dynamic shape | |||
| hidden_states = ( | |||
| hidden_states.permute(0, 2, 1).reshape_as(hidden_states_in).contiguous() | |||
| hidden_states.reshape_as(residual.permute(0, 2, 3, 1)) | |||
| .permute(0, 3, 1, 2) | |||
There was a problem hiding this comment.
reshape后面的permute得保留，避免破坏NCHW->NHWC转换后permute消除的优化。
hjchen2
commented
Jan 30, 2024
| @@ -382,9 +382,9 @@ def forward( | |||
| # height * width, batch_size, 1, time_context.shape[-1] | |||
| # ) | |||
| # Rewrite for onediff SVD dynamic shape | |||
| broadcast_tensor = hidden_states.flatten(2, 3).permute(2, 0, 1) | |||
| broadcast_tensor = hidden_states.flatten(2, 3) | |||
There was a problem hiding this comment.
这里减少一个permute，尽管还是多了一次flatten，但flatten支持view，不会产生实际的kernel计算开销
lixiang007666
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.