Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add data-1p-ignore to SearchableSelect #281

Closed
wants to merge 2 commits into from
Closed

add data-1p-ignore to SearchableSelect #281

wants to merge 2 commits into from

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Sep 6, 2024

Added

  • Added data-1p-ignore to SearchableSelect. Docs

Feature branch checklist

  • Documentation (README, etc.)
  • Run make format, make dry and make install

@briskt briskt requested a review from hobbitronics September 6, 2024 02:42
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hobbitronics
hobbitronics reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you either add a commit with message add(SearchableSelect): add data-1p-ignore to SearchableSelect or rebase so it has that commit message. Otherwise the automated stuff won't happen.

@briskt briskt closed this Sep 9, 2024
@briskt
Copy link
Contributor Author

briskt commented Sep 9, 2024

Replaced by #282

@briskt briskt deleted the briskt-patch-1 branch October 9, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics