Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 11.5.0 -- added data-1p-ignore #284

Merged
merged 12 commits into from
Sep 9, 2024
Merged

Release 11.5.0 -- added data-1p-ignore #284

merged 12 commits into from
Sep 9, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Sep 9, 2024

Added

  • Added data-1p-ignore to inputs that should not trigger 1Password for autofill. Adding a autocomplete="off" attribute doesn't always block it. (e.g. Setting placeholder to "SuiteKey" triggers the 1Password extension to add its icon.

briskt and others added 11 commits September 6, 2024 14:41
### [11.4.2](v11.4.1...v11.4.2) (2024-09-06)

### Fixed

* **Drawer:** fix A11y warning in Drawer ([275d2b9](275d2b9))
…props

add data-1p-ignore to prevent 1Password trying to fill
## [11.5.0](v11.4.2...v11.5.0) (2024-09-09)

### Added

* **DateInput:** add data-1p-ignore to prevent 1Password trying to fill ([c296811](c296811))
* **MoneyInput:** add data-1p-ignore to prevent 1Password trying to fill ([6367aa8](6367aa8))
* **SearchableSelect:** add data-1p-ignore to SearchableSelect ([ce4bf4b](ce4bf4b))
* **Select:** add data-1p-ignore to prevent 1Password trying to fill ([1e502e2](1e502e2))
@briskt briskt requested a review from hobbitronics September 9, 2024 03:31
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some redundant lines in the CHANGELOG but otherwise good

CHANGELOG.md Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Sep 9, 2024

@briskt briskt merged commit 6641816 into main Sep 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants