Add web3_clientversion rpc #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vid201
requested changes
May 26, 2023
zsluedem
force-pushed
the
add-web3client
branch
2 times, most recently
from
0d19b50
to
9ff8e99
Compare
Vid201
reviewed
May 26, 2023
crates/rpc/src/custom_api.rs
Outdated
| use jsonrpsee::{core::RpcResult, proc_macros::rpc}; | ||
|
|
||
| #[rpc(server)] | ||
| pub trait CustomApi { |
There was a problem hiding this comment.
I think it would be better to have web3.rs and web3_api.rs instead of custom, to follow the same pattern.
Vid201
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.