Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change building env and thirdparty library for user to build as library #178

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Change building env and thirdparty library for user to build as library #178

merged 4 commits into from
Jul 28, 2023

Conversation

zsluedem
Copy link
Collaborator

@zsluedem zsluedem commented Jul 28, 2023 •
edited
Loading

Trying to fix this one #175

@zsluedem zsluedem requested a review from Vid201 July 28, 2023 05:46
@zsluedem zsluedem linked an issue Jul 28, 2023 that may be closed by this pull request
CARGO_WORKSPACE_DIR not set during runtime error when crates are exported #175
Closed
@zsluedem
Copy link
Collaborator Author

@Vid201 Temporary fix now. Ultimately would use alloy.

Vid201
Vid201 requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this should solve the problem in the meantime

I am wondering if it's better to keep thirdparty folder -> meaning tests/thirdparty/bundler and crates/contracts/thirdparty/account-abstraction to indicate third party repos. Not sure if needed though

Makefile Outdated Show resolved Hide resolved
Vid201
Vid201 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

@zsluedem zsluedem merged commit 865801d into silius-rs:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vid201 Vid201 Vid201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CARGO_WORKSPACE_DIR not set during runtime error when crates are exported
2 participants
@zsluedem @Vid201