Validate tests

[zsluedem]

** You have to install Yarn and foundry to make it work**

Install foundry

This is the rust codes of validating tests in https://github.com/eth-infinitism/bundler/blob/main/packages/bundler/test/ValidateManager.test.ts .

1. The pr introduce foundry as a testing evm node which would provide enough function for bundler to interact with.
2. Include bundler repo
3. Introduces the validating test cases.
4. Enable clippy lint in tests.

[Vid201]

This is good, will be very helpful 🚀

[zsluedem]

@Vid201 You have to implement this method for validations you wrote in your pr.

[zsluedem]

@Vid201 The #[should_panic] flag should be removed when the validating function is implemented. The case panic right now is because validate always return Ok

[Vid201]

Looks good @zsluedem. I wonder if these tests will stay relevant in the future or if we should focus on https://github.com/eth-infinitism/bundler-spec-tests. This was released two weeks ago and will be the official test suite for bundlers (maybe integrate running these tests instead in the repo).

What do you think?

[zsluedem]

Looks good @zsluedem. I wonder if these tests will stay relevant in the future or if we should focus on https://github.com/eth-infinitism/bundler-spec-tests. This was released two weeks ago and will be the official test suite for bundlers (maybe integrate running these tests instead in the repo).

What do you think?

Hm...I didn't know the test suite. I read the test codes there today and compare. They got very similar test contracts for opcode-banning parts.

The test suite would be run with a bundler client and an execution client from higher-layer integration perspective. I think we could have both because this could help you develop the simulation checking function (I think). You don't need to have a fully functional bundler to run the test suite right now.

But I am Ok if you want to just use the test suite.

[Vid201]

Looks good @zsluedem. I wonder if these tests will stay relevant in the future or if we should focus on https://github.com/eth-infinitism/bundler-spec-tests. This was released two weeks ago and will be the official test suite for bundlers (maybe integrate running these tests instead in the repo).
What do you think?

Hm...I didn't know the test suite. I read the test codes there today and compare. They got very similar test contracts for opcode-banning parts.

The test suite would be run with a bundler client and an execution client from higher-layer integration perspective. I think we could have both because this could help you develop the simulation checking function (I think). You don't need to have a fully functional bundler to run the test suite right now.

But I am Ok if you want to just use the test suite.

Ok, great. I didn't go into many details yet. Let's have both tests then, one for easier and faster development, and the other for validating everything and getting official results.

[Vid201]

LGTM 🚀