Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce metrics #278

Merged
merged 1 commit into from
Jan 24, 2024
Merged

feat: introduce metrics #278

merged 1 commit into from
Jan 24, 2024

Conversation

zsluedem
Copy link
Collaborator

No description provided.

@zsluedem zsluedem requested a review from Vid201 as a code owner January 17, 2024 14:09
@zsluedem zsluedem force-pushed the metrics branch 3 times, most recently from dcbc058 to c4192fd Compare January 18, 2024 06:47
@Vid201 Vid201 linked an issue Jan 18, 2024 that may be closed by this pull request
Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!! left some comments

crates/primitives/src/label.rs Outdated Show resolved Hide resolved
bin/silius/src/bundler.rs Outdated Show resolved Hide resolved
bin/silius/src/metrics.rs Outdated Show resolved Hide resolved
Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

Left just one small nitpick

bin/silius/src/cli/args.rs Outdated Show resolved Hide resolved
@zsluedem zsluedem merged commit 456e5b3 into silius-rs:main Jan 24, 2024
2 checks passed
@zsluedem zsluedem deleted the metrics branch January 24, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a metrics system
2 participants