Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace anvil with Geth #40

Merged
merged 6 commits into from
Jan 30, 2023
Merged

Replace anvil with Geth #40

merged 6 commits into from
Jan 30, 2023

Conversation

zsluedem
Copy link
Collaborator

@zsluedem zsluedem commented Jan 20, 2023

Sadly anvil test node support debug_tracecall with javascript tracer. It would be better to switch to geth dev mode which support javascript tracer.

@zsluedem zsluedem force-pushed the use-geth branch 2 times, most recently from 939fbb5 to 70e901b Compare January 22, 2023 13:58
README.md Outdated Show resolved Hide resolved
@zsluedem
Copy link
Collaborator Author

zsluedem commented Jan 29, 2023

blocked by gakonst/ethers-rs#2088 now

@zsluedem zsluedem marked this pull request as ready for review January 29, 2023 13:49
@zsluedem zsluedem requested a review from Vid201 January 29, 2023 13:50
@zsluedem
Copy link
Collaborator Author

@Vid201 I marked this pr to be ready to review now. And I put the additional tracer stuff into #44 and I would make another pr for it. But I am not sure whether you got ongoing work related. I just want to notify you in case we have dup works.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Vid201
Copy link
Member

Vid201 commented Jan 29, 2023

@Vid201 I marked this pr to be ready to review now. And I put the additional tracer stuff into #44 and I would make another pr for it. But I am not sure whether you got ongoing work related. I just want to notify you in case we have dup works.

That's fine, I sent you my progress on tracer on Discord.

This PR looks good, I left two small comments to change some text only.

@zsluedem zsluedem merged commit ae1e715 into silius-rs:main Jan 30, 2023
@zsluedem zsluedem deleted the use-geth branch January 30, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants