Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle config coming from CONFIG_D directory #21

Merged
merged 3 commits into from
Nov 16, 2018
Merged

Conversation

bohwaz
Copy link
Contributor

@bohwaz bohwaz commented Nov 16, 2018

Fix #20

Using some code from Dehydrated

@silkeh
Copy link
Owner

silkeh commented Nov 16, 2018

Thanks! Can you fix the following shellcheck complaints?

In pdns_api.sh line 106:
    [[ -n "${ZSH_VERSION:-}" ]] && set +o noglob || set +f
                                ^-- SC2015: Note that A && B || C is not if-then-else. C may run when A is true.

In pdns_api.sh line 119:
    [[ -n "${ZSH_VERSION:-}" ]] && set -o noglob || set -f
                                ^-- SC2015: Note that A && B || C is not if-then-else. C may run when A is true.

@bohwaz
Copy link
Contributor Author

bohwaz commented Nov 16, 2018

Sorry no idea what that line does, just copied the code from dehydrated :)

@silkeh
Copy link
Owner

silkeh commented Nov 16, 2018

In that case: 1) add a note that the code is based on dehydrated, and 2) add # shellcheck disable=SC2015 above the two lines.

@bohwaz
Copy link
Contributor Author

bohwaz commented Nov 16, 2018

OK actually fixed the code, it's better than ignoring a warning. Note added.

pdns_api.sh Outdated Show resolved Hide resolved
@silkeh silkeh merged commit 6bcbb62 into silkeh:master Nov 16, 2018
@silkeh
Copy link
Owner

silkeh commented Nov 16, 2018

Merged. Thanks!

@bohwaz
Copy link
Contributor Author

bohwaz commented Nov 16, 2018

No prob, thanks to you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants