fix: tag parsing for reopening

[nabalone]

This change is 

[andrew-polk]

Reviewed 21 of 21 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @nabalone)

---

components/language-chooser/common/find-language/languageTagUtils.spec.ts line 37 at r1 (raw file):

describe("get shortest equivalent version of langtag", () => {
  it("should return the shortest tag if it exists", () => {

What should happen if it doesn't exist?
Same for maximal.

---

components/language-chooser/common/find-language/README.md line 129 at r1 (raw file):

### Language data processing pipeline

If you modify [langtagProcessing.ts](./langtagProcessing.ts), run `npm run find-language/common/langtag-processing` to update [languageData.json](language-data/languageData.json) and [equivalentTags.json](language-data/equivalentTags.json).

Should we be deleting shortestTagLookups.json?

---

components/language-chooser/react/language-chooser-react-mui/src/demos/DialogDemo.tsx line 115 at r1 (raw file):

    props.alreadyFilled ? samplePrefilledSelections : ({} as IOrthography)
  );
  // Language tag can also be computed from the IOrthography object using createTagFromOrthography

Looks like you decided to use the function here now?
So I think this comment is stating you could do what you are doing?
So it ends up confusing.

[nabalone]

Reviewable status: 16 of 22 files reviewed, 3 unresolved discussions (waiting on @andrew-polk)

---

components/language-chooser/common/find-language/languageTagUtils.spec.ts line 37 at r1 (raw file):

Previously, andrew-polk wrote…

What should happen if it doesn't exist?
Same for maximal.

Done. Returns undefined

---

components/language-chooser/common/find-language/README.md line 129 at r1 (raw file):

Previously, andrew-polk wrote…

Should we be deleting shortestTagLookups.json?

Done.

---

components/language-chooser/react/language-chooser-react-mui/src/demos/DialogDemo.tsx line 115 at r1 (raw file):

Previously, andrew-polk wrote…

Looks like you decided to use the function here now?
So I think this comment is stating you could do what you are doing?
So it ends up confusing.

Done. Yeah, oops

[andrew-polk]

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nabalone)