Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word Export: LT-21891: Add guidewords for reversals #225

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

mark-sil
Copy link
Contributor

@mark-sil mark-sil commented Dec 5, 2024

Change-Id: I737e73956a413561a338738050f847316f6e3089


This change is Reviewable

Change-Id: I737e73956a413561a338738050f847316f6e3089
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mark-sil)


Src/xWorks/LcmWordGenerator.cs line 74 at r1 (raw file):

				settings.StylesGenerator.AddGlobalStyles(configuration, readOnlyPropertyTable);
				string lastHeader = null;
				string firstGuidewordStyle = null;

👏 Nice renaming!

@jasonleenaylor jasonleenaylor merged commit 314ab9c into release/9.1 Dec 5, 2024
5 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-21891b branch December 5, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants