Fix style export for undefined structure and function #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papeh
force-pushed
the
fix/LT-20895
branch
4 times, most recently
from
863cb55 to
42c9bba
Compare
papeh
changed the title
This comment has been minimized.
This comment has been minimized.
The initial fix to LT-20393 caused a regression with the same steps as LT-20895. Fix the style export update so that the legacy style import continues to work. Also: * Modernize the import * Update a message about the installation CD * Fix incorrect exception messages regarding the import Change-Id: I7b6e120246cce9614d1a88a8a42b9145d61d5841
* Remove some TE-specific code * Fix the comment on EnsureCompatibleFactoryStyle Change-Id: I610d98564e14c36eb9f2e9a9f28d62acf59219c5
Change-Id: Ia02602d5162747fe480723a6515b1ffcacbeb3e9
Change-Id: I5254909decfc953fd9fa157b8c768d8efd214000
during Dict View import TODO: unit test FUTURE WORK: rewrite the style import to handle importing shared user styles differently from loading new installed styles Change-Id: Ia05179990090fe118c4a26081d5654da5917e0de
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial fix to LT-20393 caused a regression with the same steps as LT-20895. Fix the style export update so that the legacy style import continues to work.
DONE: Update Style exports to be importable (export Structure and Function when not the default value)
TODO: figure out how to import Dictionary Views exported from previous FLEx versions
Also:
Change-Id: I7b6e120246cce9614d1a88a8a42b9145d61d5841
This change is