Get unit tests running again in Docker containers #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main change we had to account for was the change to LfMergeSettings and how it now takes environment variables as settings. The LfMergeSettings test doubles now set the vars they need before calling SetAllMembers().
We skip integration tests by default in unit testing. This will be configurable with a build arg to the Docker container so that we can run the slow integration tests as well if we want to.
|
This PR's logic was incorporated into #284, which has been merged and released. It's no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests were failing after switching the LfMerge build to a Dockerized environment. This PR gets them working again, at least on the FW 9 branch. (A separate PR will be needed for the FW 8 branch, of course).
The main change we had to account for was the change to LfMergeSettings and how it now takes environment variables as settings. The LfMergeSettings test doubles now set the vars they need before calling SetAllMembers().
NOTE: This PR does not run unit tests by default in the build, because they take too long (20+ minutes) to be useful. Instead, I intend to create another PR that divides the tests up into fast and slow tests, then runs the fast tests with every PR and allows us to run the slow tests on-demand.
This change is