Skip to content

Commit

Permalink
Merge branch 'master' into arm
Browse files Browse the repository at this point in the history
  • Loading branch information
imnasnainaec authored Nov 15, 2024
2 parents 3fd2eb2 + 6e1b47c commit 28a2ced
Show file tree
Hide file tree
Showing 7 changed files with 31 additions and 27 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,10 @@ jobs:
egress-policy: block
allowed-endpoints: >
api.github.com:443
api.codecov.io:443
cli.codecov.io:443
codecov.io:443
github.com:443
ingest.codecov.io:443
storage.googleapis.com:443
uploader.codecov.io:443
- name: Checkout repository
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- name: Download coverage artifact
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/deploy_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
egress-policy: block
allowed-endpoints: >
*.actions.githubusercontent.com:443
*.cloudfront.net:443
*.data.mcr.microsoft.com:443
api.ecr-public.us-east-1.amazonaws.com:443
api.github.com:443
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,10 @@ jobs:
egress-policy: block
allowed-endpoints: >
api.github.com:443
api.codecov.io:443
cli.codecov.io:443
codecov.io:443
github.com:443
ingest.codecov.io:443
storage.googleapis.com:443
uploader.codecov.io:443
- name: Checkout repository
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- name: Download coverage artifact
Expand Down
43 changes: 25 additions & 18 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -731,16 +731,20 @@ Install the Kubernetes resources to run _The Combine_ by running:
python deploy/scripts/setup_combine.py [--target <target_name>] [--tag <image_tag>]
```
The default target is `localhost`; the default tag is `latest`. For development testing the script will usually be run
with no arguments.
Notes:
If an invalid target is entered, the script will list available targets and prompt the user his/her selection.
`deploy/scripts/setup_combine.py` assumes that the `kubectl` configuration file is setup to manage the desired
Kubernetes cluster. For most development users, there will only be the _Rancher Desktop/Docker Desktop_ cluster to
manage and the installation process will set that up correctly. If there are multiple clusters to manage, the
`--kubeconfig` and `--context` options will let you specify a different cluster.
- The default target is `localhost`; the default tag is `latest`. For development testing the script will usually be run
with no arguments.
Run the script with the `--help` option to see possible options for the script.
- If an invalid target is entered, the script will list available targets and prompt the user his/her selection.
`deploy/scripts/setup_combine.py` assumes that the `kubectl` configuration file is setup to manage the desired
Kubernetes cluster. For most development users, there will only be the _Rancher Desktop/Docker Desktop_ cluster to
manage and the installation process will set that up correctly. If there are multiple clusters to manage, the
`--kubeconfig` and `--context` options will let you specify a different cluster.
- Run the script with the `--help` option to see possible options for the script.
- The setup assumes `amd64` architecture. If the target architecture is `arm64`, add `--set global.cpuArch=arm64`.
When the script completes, the resources will be installed on the specified cluster. It may take a few moments before
all the containers are up and running. If you are using _Rancher Desktop_, you can use the
Expand All @@ -749,22 +753,25 @@ all the containers are up and running. If you are using _Rancher Desktop_, you c
```console
$ kubectl -n thecombine get deployments
NAME READY UP-TO-DATE AVAILABLE AGE
backend 1/1 1 1 10m
database 1/1 1 1 10m
frontend 1/1 1 1 10m
maintenance 1/1 1 1 10m
NAME READY UP-TO-DATE AVAILABLE AGE
backend 1/1 1 1 10m
database 1/1 1 1 10m
frontend 1/1 1 1 10m
maintenance 1/1 1 1 10m
otel-opentelemetry-collector 1/1 1 1 19m
```
or
```console
$ kubectl -n thecombine get pods
NAME READY STATUS RESTARTS AGE
backend-5657559949-z2flp 1/1 Running 0 10m
database-794b4d956f-zjszm 1/1 Running 0 10m
frontend-7d6d79f8c5-lkhhz 1/1 Running 0 10m
maintenance-7f4b5b89b8-rhgk9 1/1 Running 0 10m
NAME READY STATUS RESTARTS AGE
backend-5657559949-z2flp 1/1 Running 0 10m
database-794b4d956f-zjszm 1/1 Running 0 10m
frontend-7d6d79f8c5-lkhhz 1/1 Running 0 10m
install-fonts-4jcsl 0/1 Completed 0 8m
maintenance-7f4b5b89b8-rhgk9 1/1 Running 0 10m
otel-opentelemetry-collector-5b5b69557b-zqk5d 1/1 Running 0 19m
```
### Connecting to Your Cluster
Expand Down
2 changes: 1 addition & 1 deletion deploy/helm/aws-login/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ global:
awsAccessKeyId: "Override"
awsSecretAccessKey: "Override"
pullSecretName: aws-login-credentials
cpuArch: "arm64"
cpuArch: "amd64"

awsEcr:
configName: aws-ecr-config
Expand Down
2 changes: 1 addition & 1 deletion deploy/helm/thecombine/charts/maintenance/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ global:
imageRegistry: ""
# Default AWS S3 location
awsS3Location: "thecombine.app"
cpuArch: "arm64"
cpuArch: "amd64"

imageName: combine_maint

Expand Down
2 changes: 1 addition & 1 deletion deploy/scripts/app_release.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def get_release() -> str:
num_commits = match[2]
# Get the branch name
result = run_cmd(["git", "branch", "--show-current"], chomp=True)
branch_name = re.sub("[/_]+", "-", result.stdout)
branch_name = re.sub("[/_]+", "-", result.stdout) or "HEADLESS"
return f"{release_string}-{branch_name}.{num_commits}"
message = f"Unrecognized release value in tag: {result.stdout}"
raise ValueError(message)
Expand Down

0 comments on commit 28a2ced

Please sign in to comment.