Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on deprecated WebApiCompatShim #1220

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Jun 26, 2021

Closes #1214

This is a follow on of the work that has proceeded to eliminate remaining usages of deprecated ASP.NET 2.2 features from the code base.


This change is Reviewable

@johnthagen johnthagen added backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. dependencies Pull requests that update a dependency file labels Jun 26, 2021
@johnthagen johnthagen requested a review from imnasnainaec June 26, 2021 13:50
@johnthagen johnthagen self-assigned this Jun 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2021

Codecov Report

Merging #1220 (5e617f5) into master (cf05e0d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1220   +/-   ##
=======================================
  Coverage   45.37%   45.37%           
=======================================
  Files         266      266           
  Lines        8110     8110           
  Branches      528      528           
=======================================
  Hits         3680     3680           
  Misses       4014     4014           
  Partials      416      416           
Flag Coverage Δ
backend 58.43% <0.00%> (ø)
frontend 33.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Backend/Controllers/UserController.cs 41.07% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf05e0d...5e617f5. Read the comment docs.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)

@imnasnainaec imnasnainaec merged commit d8ff096 into master Jun 28, 2021
@imnasnainaec imnasnainaec deleted the remove-mvc-shim branch June 28, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dependencies Pull requests that update a dependency file maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated usage of Microsoft.AspNetCore.Mvc.WebApiCompatShim
3 participants