Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Python dependencies & use mypy strict mode #1238

Merged
merged 4 commits into from
Jul 2, 2021
Merged

Upgrade Python dependencies & use mypy strict mode #1238

merged 4 commits into from
Jul 2, 2021

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Jul 2, 2021 •
edited
Loading

Upgrade Python dependencies.

  • Specifically update to mypy 0.9xx which allows us to move its configuration into pyproject.toml so all Python tools are configured in a single location. This allows us to delete the setup.cfg file.
  • Enable mypy strict mode, to increase type checking within Python code
    • Fix some type issues revealed using this flag
  • Also manually pin isort to version 5.8.0 for now to avoid this issue: skips are not honored since isort 5.9.x PyCQA/isort#1762
  • Update User Guide config to be compatible with the latest MkDocs

This change is Reviewable

@johnthagen johnthagen added python dependencies Pull requests that update a dependency file labels Jul 2, 2021
@johnthagen johnthagen self-assigned this Jul 2, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@johnthagen johnthagen changed the title Upgrade Python dependencies Upgrade Python dependencies & use mypy strict mode Jul 2, 2021
@johnthagen johnthagen marked this pull request as ready for review July 2, 2021 17:00
@johnthagen johnthagen requested a review from jmgrady July 2, 2021 17:00
jmgrady
jmgrady approved these changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 8 of 8 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)

@johnthagen johnthagen merged commit c19a4e9 into master Jul 2, 2021
@johnthagen johnthagen deleted the bump-python-deps branch July 2, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmgrady jmgrady jmgrady approved these changes

Assignees

@johnthagen johnthagen

Labels
dependencies Pull requests that update a dependency file python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnthagen @codecov-commenter @jmgrady